[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [cp-patches] Speed up java.nio.ByteBuffer
From: |
Florian Weimer |
Subject: |
Re: [cp-patches] Speed up java.nio.ByteBuffer |
Date: |
Thu, 12 Aug 2004 20:01:20 +0200 |
* Michael Koch:
> Am Donnerstag, 12. August 2004 19:32 schrieb Florian Weimer:
>> On GCJ, this patch results in a 18% improvement in speed for
>> loading databases with Berkeley DB Java Edition. Regression-tested
>> (modulo changes in comments) with GCJ and a DbLoad/DbDump with JE.
>>
>> Further improvements will require a new class for a read-only byte
>> buffer, so that the read-only flag can go. Where should I put this
>> one?
>
> Do you realy think it is a good idea to just introduce a new class (or
> some of them) for read-only buffers ? isnt the flag not enough ?
We could remove all calls to checkIfReadOnly() as a result; in the new
class, put() would simply throw ReadOnlyBufferException.
>> What are the necessary steps to get the patches installed? Should
>> I install them in the GCC repository first?
>
> Is your copyright assignment through ? Do you have access to Classpath
> CVS ?
I've got an assignment on file for GCC. Does it cover Classpath?
> Your coding style is broken. "{" and "}" have to go in their own line,
> indented by two spaces. Then "content" in them is again indented by
> two spaces.
Ah, GNU coding style. I don't think I'll ever get used to it. 8-)
> This patch is beautiful. When you tell me your assignment is done I
> will commit it as soon as possible.
What about the typo fix I sent a few days ago? Without it, JE doesn't
work at all.