Re: [cp-patches] Patch: java/lang/Runtime.java

[Mark Wielaard]

Hi,

On Thu, 2004-09-02 at 12:50, Jeroen Frijters wrote:
> I was playing around with a security manager and JNI and discovered some
> differences between Sun's security checks and our's, so I fixed them.
> 
> Comments?

ChangeLog entry? Really those are nice to have when reviewing a patch to
see what was intended to be changed.

The change looks fine. Please check it in.

> +   * @param filename the file to load
> +   * @return 0 on failure, nonzero on success
> +   * @throws SecurityException if fil read permission is denied

Typo fil -> file.

> BTW, does anyone know if (and how) a VM is supposed to do a security
> check when a native method is linked?

I thought the only check is done when a library is loaded (which
contains the native methods).

Cheers,

Mark

signature.asc
Description: This is a digitally signed message part