[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [cp-patches] [Patch] java.net.InetAddress
From: |
Michael Koch |
Subject: |
Re: [cp-patches] [Patch] java.net.InetAddress |
Date: |
Wed, 13 Oct 2004 14:57:29 +0200 |
User-agent: |
KMail/1.6.2 |
On Wednesday 13 October 2004 14:48, Dalibor Topic wrote:
> Jeroen Frijters wrote:
> > Michael Koch wrote:
> >>On Wednesday 13 October 2004 13:19, Jeroen Frijters wrote:
> >>>Michael Koch wrote:
> >>>>I wrote the attached patch to add the missing method
> >>>>java.net.InetAddress.getCanonicalHostName().
> >>>
> >>>I haven't tried the patch yet, but the following looks wrong:
> >>>
> >>>+ // Try to find the FDQN now
> >>>+ InetAddress address = new Inet4Address(getAddress(), null);
> >>>+ return address.getHostName();
> >>>
> >>>Shouldn't that be:
> >>>
> >>>+ // Try to find the FDQN now
> >>>+ InetAddress address =
> >>> InetAddress.getByAddress(getAddress()); + return
> >>> address.getHostName();
> >>
> >>In this case: it doesnt matter, the result is the same. If
> >>hostname is null getHostName() does a lookup. Calling
> >> getByAddress is IMHO too much not needed work like getting all
> >> hostnames for an address instead of only one.
> >
> > I was thinking about IPv6 addresses, wouldn't they go wrong with
> > your code?
>
> Code that assumes Inet4 addresses for localhost would fail on an
> IPv6 only host, afaict.
That's right. I need to write some mauve testcases for IPv6.
Michael
- RE: [cp-patches] [Patch] java.net.InetAddress, (continued)
- RE: [cp-patches] [Patch] java.net.InetAddress, Jeroen Frijters, 2004/10/13
- RE: [cp-patches] [Patch] java.net.InetAddress, Jeroen Frijters, 2004/10/13
- Re: [cp-patches] [Patch] java.net.InetAddress, Michael Koch, 2004/10/13
- Re: [cp-patches] [Patch] java.net.InetAddress, Dalibor Topic, 2004/10/13
- Re: [cp-patches] [Patch] java.net.InetAddress, Michael Koch, 2004/10/13
- Re: [cp-patches] [Patch] java.net.InetAddress, Michael Koch, 2004/10/15
- Re: [cp-patches] [Patch] java.net.InetAddress, Dalibor Topic, 2004/10/15
- Re: [cp-patches] [Patch] java.net.InetAddress, Michael Koch, 2004/10/15
Re: [cp-patches] [Patch] java.net.InetAddress, Dalibor Topic, 2004/10/13
- Re: [cp-patches] [Patch] java.net.InetAddress,
Michael Koch <=