[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [cp-patches] [Patch] import cleanup
From: |
Michael Koch |
Subject: |
Re: [cp-patches] [Patch] import cleanup |
Date: |
Fri, 15 Oct 2004 08:04:09 +0200 |
User-agent: |
KMail/1.6.2 |
On Thursday 14 October 2004 23:10, Mark Wielaard wrote:
> Hi,
>
> On Wed, 2004-10-13 at 16:33, Michael Koch wrote:
> > I just commited the attached patch to cleanup some import
> > statements all over gnu.* packages. This patch was influenced by
> > patch #3128. Thanks to Nikolay Fiykov.
> > [...]
> >
> > diff -u -r1.2 StubDelegateImpl.java
> > --- gnu/javax/rmi/CORBA/StubDelegateImpl.java 29 Jul 2004
> > 06:12:04 -0000 1.2 +++
> > gnu/javax/rmi/CORBA/StubDelegateImpl.java 13 Oct 2004 14:31:05
> > -0000 @@ -41,17 +41,9 @@
> > import java.io.IOException;
> > import java.io.ObjectInputStream;
> > import java.io.ObjectOutputStream;
> > -//import org.omg.CORBA.portable.Delegate;
> > -//import org.omg.CORBA.portable.InputStream;
> > -//import org.omg.CORBA.portable.OutputStream;
> > -//import org.omg.CORBA_2_3.portable.ObjectImpl;
> > -//import org.omg.CORBA.portable.ObjectImpl;
> > -//import org.omg.CORBA.BAD_OPERATION;
> > -//import org.omg.CORBA.ORB;
> > import java.rmi.RemoteException;
> > import javax.rmi.CORBA.Stub;
> > import javax.rmi.CORBA.StubDelegate;
> > -import javax.rmi.CORBA.Tie;
>
> Note that these commented out imports indicated that this class was
> mostly bogus. It was probably my mistake to check it in.
> Jeff said he wanted to work on the Corba stuff, but maybe it is
> better to remove these bogus classes for now. What do you think?
I'm fine with this. This was exactly the reason why it got removed
from libgcj. Shall I remove it in GNU classpath too ?
Michael