RE: [cp-patches] StringBuilder and Appendable for CVS HEAD

[Jeroen Frijters]

Andrew John Hughes wrote:
> I agree; but this is code which has sat in the generics branch for
> several months, not something that has just been put together.  Also,
> this is something which will allow Classpath to work with 
> existing code that just happens to be compiled with a 1.5 compiler
> (which does a StringBuffer for StringBuilder substitution in String
> use) but has no actual 1.5 changes.

I reviewed the patch and thought about the co-variant return type issue
and I think it is safe to put in.

However, note that the current implementation is not correct
(thread/memory model safe). It's going to be quite tricky to efficiently
convert a StringBuilder into a String without creating potential
security holes.

Regards,
Jeroen