Re: [cp-patches] StringBuilder and Appendable for CVS HEAD

[Tom Tromey]

>>>>> "Jeroen" == Jeroen Frijters <address@hidden> writes:

Jeroen> In the String(StringBuilder) constructor:
Jeroen> +            buffer.shared = true;
Jeroen> +            value = buffer.value;

I thought the synchronized block in this method would force a commit
of "shared".  I'm not an expert on the memory model though.

Anyway, I'd prefer we find a way to make it possible not to reallocate
the characters when constructing the String.  It seems to me that
sharing is optimizing for the common case.  Probably, most uses of
StringBuilder will be to implement "String +".

Tom