Re: [cp-patches] jni global ref patch

[Thomas Fitzsimmons]

On Tue, 2005-02-08 at 16:57 -0500, Thomas Fitzsimmons wrote:
> On Tue, 2005-02-01 at 16:36 -0700, Craig Black wrote:
> > Hello,
> > The attached patch fixes a couple of places where local jni references
> > were being used with signal handlers. The patch also fixes an issue with
> > state table entries being destroyed too soon. Comments?
> > 
> > Craig
> > 
> > 2005-02-01  Craig Black  <address@hidden>
> > 
> >   * native/jni/gtk-peer/gnu_java_awt_peer_gtk_GdkGraphics.c
> >   (copyState): Pass a JNI global reference to signal handler.
> >   (realize_cb): Use and free JNI global reference.
> > 
> >   * native/jni/gtk-peer/gnu_java_awt_peer_gtk_GtkChoicePeer.c
> >   (create): Pass a JNI global reference to signal handler.
> >   (selection_changed): Match declaration.
> > 
> >   * native/jni/gtk-peer/gnu_java_awt_peer_gtk_GtkGenericPeer.c
> >   (dispose): Do not remove entries from state tables until after widget is
> > destroyed.
> > 
> 
> This is great; please commit.
> 

Sorry, I missed Mark's previous approval message; I agree with his
suggestions and I now realize you've already committed this.  I'll try
to keep up in the future :) Thanks,

Tom