classpath-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [cp-patches] ChannelReader .. again


From: Michael Koch
Subject: Re: [cp-patches] ChannelReader .. again
Date: Fri, 18 Feb 2005 06:26:41 -0600
User-agent: Mutt/1.5.6+20040907i

On Fri, Feb 18, 2005 at 03:43:33AM +0100, Robert Schuster wrote:
> Hi.
> I think I have fixed the remaining bits in the ChannelReader. This patch 
> adds support for the two missing constructors in 
> java.io.InputStreamReader and implements both variants of 
> java.nio.newChannel correctly (not being stubs anymore).
> 
> 2005-02-18  Robert Schuster  <address@hidden>
> 
>        * java/nio/channels/Channels: Added FIXMEs about
>        stub method implementation.
>        (newReader): Implemented.
>        * java/io/InputStreamReader:
>        (InputStreamReader(InputStream, Charset)): Implemented.
>        (InputStreamReader(InputStream, CharsetDecoder)): Implemented.
>        * gnu/java/nio/ChannelReader: New class.
> 
> If no one objects I want to have this in for 0.14

Can you please use "//" for inline comments and not "/* ... */".
This is afaik much easier to read.


Michael




reply via email to

[Prev in Thread] Current Thread [Next in Thread]