|
From: | Meskauskas Audrius |
Subject: | [cp-patches] No more suggestions for formatting the javax.swing.timer |
Date: | Sat, 26 Feb 2005 21:21:27 +0100 |
The javadoc for queueLock is a bit suspicios. Perhaps it should better read as "Locking object for the queue.".
This is true.The Java programming language does not allow to put a lock on the 'long', only on objects, and Ronald clearly needed to lock access to this variable. All alterations of the queue field are inside the synchronized(queueLock) {}.
This is a formatting/documenting patch that does not change the code. It does not fix any bugs, does not approach us to 1.2 and does not improve the performance. Taking this into consideration, I do not think that it really deserves so much attention from both you and me. I think I am far more useful for the project writing Mauve tests and explaining with patches that these test find.
I suggest to check, which version (mine or the previous one) is better and, if mine commented version is at least a little better, commit it to CVS. If the previous version is better, we can leave it as it is. If you think that this path deserves you additional time, you may modify it again before committing. Also, if the general Classpath rules do not count fixing two bugs and documenting headers as a sufficient contribution, you can remove my @author tag and sorry about that.
Cheers Audrius
[Prev in Thread] | Current Thread | [Next in Thread] |