classpath-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [cp-patches] Aelfred2 cleanup patch


From: Michael Koch
Subject: Re: [cp-patches] Aelfred2 cleanup patch
Date: Sun, 27 Feb 2005 14:02:23 +0100
User-agent: mutt-ng 1.5.8i (Debian)

On Sun, Feb 27, 2005 at 12:42:31PM +0000, Chris Burdess wrote:
> I'd like to apply the following patch to Classpath in order to
> improve readability and maintainability of the Aelfred2 SAX parser. It's
> pretty huge,  but there are few logical changes and it has been tested with
> no regressions. Please let me know what you think.
> 
> 2005-02-27  Chris Burdess  <address@hidden>
>          * gnu/xml/aelfred2/JAXPFactory.java,
>            gnu/xml/aelfred2/SAXDriver.java,
>            gnu/xml/aelfred2/XmlParser.java,
>            gnu/xml/aelfred2/XmlReader.java: Applied GNU Classpath source
>          code formatting conventions. Replaced arrays of Object with 
>          struct-like classes for easier maintainability. Made
>          SAXDriver.stringInterning package private to allow access from
>          XmlParser inside the loop

As always: Please submit code changes and reformatting as separate
patches. Its nearly impossible to review patches that contain both
easily. After all its your code so you should decide.


Michael




reply via email to

[Prev in Thread] Current Thread [Next in Thread]