Re: [cp-patches] FYI: some fixlets for javax.swing.plaf.basic.BasicListUI

[Michael Koch]

On Sun, Feb 27, 2005 at 05:03:42PM +0100, Roman Kennke wrote:
> I committed the attached patch, which fixes the modifiers of several
> fields, methods and inner classes of javax.swing.plaf.basic.BasicListUI
> to match the spec.
> 
> /Roman
> 

> Index: ChangeLog
> ===================================================================
> RCS file: /cvsroot/classpath/classpath/ChangeLog,v
> retrieving revision 1.3267
> diff -u -r1.3267 ChangeLog
> --- ChangeLog 27 Feb 2005 14:32:28 -0000      1.3267
> +++ ChangeLog 27 Feb 2005 16:01:19 -0000
> @@ -1,3 +1,9 @@
> +2005-02-27  Roman Kennke  <address@hidden>
> +
> +     * javax/swing/plaf/basic/BasicListUI:
> +     fixed modifiers of several fields, methods and inner
> +     classes to match the 'spec'
> +
>  2005-02-27  Chris Burdess  <address@hidden>

The ChangeLog entry should not be part of the patch. This makes applying
the patch to other trees, e.g. for merging to kaffe or gcj much harder.


>    /**
> -   * Gets the maximum size this list can assume.
> -   *
> -   * @param c The component to measure the size of
> -   *
> -   * @return A new Dimension representing the component's maximum size
> -   */
> -  public Dimension getMaximumSize(JComponent c)
> -  {
> -    return new Dimension(Integer.MAX_VALUE, Integer.MAX_VALUE);
> -  }
> -
> -  /**
>     * Gets the size this list would prefer to assume. This is calculated by

This change was not desribed in the ChangeLog entry.


Michael
-- 
Java Trap: http://www.gnu.org/philosophy/java-trap.html