[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [cp-patches] Re: FYI: java/io/FileInputStream.java& java/io/FileOutp
RE: [cp-patches] Re: FYI: java/io/FileInputStream.java& java/io/FileOutputStream.java
Wed, 9 Mar 2005 11:03:53 +0100
Dalibor Topic wrote:
> Jeroen Frijters <jeroen <at> sumatra.nl> writes:
> > 2005-03-03 Jeroen Frijters <jeroen <at> frijters.net>
> > * java/io/FileInputStream.java (FileInputStream(File)),
> > java/io/FileOutputStream.java (FileOutputStream(File)):
> > Removed unnecessary File.isDirectory() check.
> Hi Jeroen,
> while trying to merge the patch into Kaffe I noticed that it breaks
> the http://www.kaffe.org/cgi-bin/viewcvs.cgi/kaffe/test/regression/
> regression test in Kaffe. According to API docs for File*outStream,
> the File constructor is supposed to throw an exception if the file
> parameter is a directory.
> Could you elaborate some more on the patch?
This means that FileChannelImpl.open() should be fixed to throw the
proper exception. Doing the explicit check in the File[In|Out]putStream
doesn't make sense, because it is inherently racy (and inefficient too).
I didn't notice the failure because I use a custom version of
FileChannelImpl, so sorry about that.
- RE: [cp-patches] Re: FYI: java/io/FileInputStream.java& java/io/FileOutputStream.java,
Jeroen Frijters <=