[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[cp-patches] Patch: RFA: IconvCharset change

From: Tom Tromey
Subject: [cp-patches] Patch: RFA: IconvCharset change
Date: 26 Apr 2005 10:47:02 -0600
User-agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50

I found this while playing with Eclipse.  The field 'name' in this
class appears to be unused, and the assignment ' = name'
does nothing.

I don't really know this code, though, so I thought I'd post it to
make sure we aren't doing something weird with reflection.  Mark?  Sven?


2005-04-25  Tom Tromey  <address@hidden>

        * (name):
        Removed unused field.
        (IconvCharset): Updated.

Index: gnu/java/nio/charset/iconv/
RCS file: 
retrieving revision 1.1
diff -u -r1.1
--- gnu/java/nio/charset/iconv/        18 Apr 2005 11:35:14 
-0000      1.1
+++ gnu/java/nio/charset/iconv/        26 Apr 2005 16:39:29 
@@ -38,22 +38,17 @@
-import java.nio.ByteBuffer;
-import java.nio.CharBuffer;
 import java.nio.charset.Charset;
 import java.nio.charset.CharsetDecoder;
 import java.nio.charset.CharsetEncoder;
-import java.nio.charset.CoderResult;
 public final class IconvCharset extends Charset
-  private String name;
   private IconvMetaData info;
   public IconvCharset(IconvMetaData info)
     super(info.nioCanonical(), info.aliases());
- = name; = info;
     if (newEncoder() == null || newDecoder() == null)
       throw new IllegalArgumentException();

reply via email to

[Prev in Thread] Current Thread [Next in Thread]