classpath-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[cp-patches] Re: Patch: PR 21372 (FileChannel.tryLock())


From: Tom Tromey
Subject: [cp-patches] Re: Patch: PR 21372 (FileChannel.tryLock())
Date: 04 May 2005 14:53:56 -0600
User-agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50

>>>>> "Andrew" == Andrew Overholt <address@hidden> writes:

Andrew> Sorry for the spam, but here's an updated version of the toString
Andrew> re-implementation (what I intended to send the first time) that uses
Andrew> StringBuffer.

Actually, one little nit:

Andrew> +    StringBuffer buf = new StringBuffer(getClass().getName());
Andrew> +    buf.append("[" + position + ":" + size);

It is better to avoid '+' here if you really want to get the benefits
of StringBuffer.  I'll make that change.

Tom




reply via email to

[Prev in Thread] Current Thread [Next in Thread]