[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[cp-patches] Re: RFC: Fixed array index in GdkGraphics2D.updateBufferedI

From: Ziga Mahkovec
Subject: [cp-patches] Re: RFC: Fixed array index in GdkGraphics2D.updateBufferedImage
Date: Tue, 14 Jun 2005 16:23:13 +0200

On Tue, 2005-06-14 at 09:49 +0200, Sven de Marothy wrote: 
> > Doing a multiplication and addition on every iteration seems quite
> > wasteful to me :)
> Doing a pixel-by-pixel copy and conversion on EVERY DRAWING OPERATION is
> quite wasteful as well. :-/ Really, let's keep our priorities in order
> here :)

Right.  To elaborate: this path is not followed for the most common case
-- single-bank (A)RGB-int sRGB-space images; however, as soon as one of
these conditions isn't met, pixelConversionRequired gets set.

> This code is one of the absolutely worst parts of Classpath and I plan
> to replace it completely later. The idea is the BufferedImage should be
> re-engineered to use native buffers on which Cairo can draw to directly.
> My plan:

This sounds great.  I suppose this fix (with Robert's improvement) is
still in place, for the time being?


reply via email to

[Prev in Thread] Current Thread [Next in Thread]