classpath-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [cp-patches] FYI: Fixlet for DataInputStream.readLine


From: Tom Tromey
Subject: Re: [cp-patches] FYI: Fixlet for DataInputStream.readLine
Date: 16 Jun 2005 11:23:21 -0600
User-agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50

>>>>> "Jeroen" == Jeroen Frijters <address@hidden> writes:

>> No. I just came over this code while merging GNU Classpath with the
>> Aicas code, where we did even worse stuff at this point. If you think
>> this is bad, I will reverse my patch. Especially in the light 
>> that this method is deprecated with the statement 'it doesn't work
>> correctly' in the JDK, this will not matter much anyway.

Jeroen> I don't know how others feel about this, but I would be more
Jeroen> comfortable if you took it out.

I agree.  For changes like this I would prefer to see a "real life"
use case where it makes a difference -- generally I prefer
maintainability (in this case, loose coupling) over performance,
except in cases where it "really matters".

Tom




reply via email to

[Prev in Thread] Current Thread [Next in Thread]