[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[cp-patches] Re: [RFA/JDWP] StringReferenceCommandSet.java
From: |
Tom Tromey |
Subject: |
[cp-patches] Re: [RFA/JDWP] StringReferenceCommandSet.java |
Date: |
29 Jun 2005 14:39:58 -0600 |
User-agent: |
Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50 |
>>>>> "Aaron" == Aaron Luchko <address@hidden> writes:
Aaron> Okay, this is the first implementation of a CommandSet.
This seems reasonable enough to me. A few nits though...
Aaron> The reason I'm still using a switch in this class
Aaron> even though there's only a single command to choose from is consistency
Aaron> with the rest of the CommandSets.
Rationale like this should go in comments in the code.
Aaron> One additional thing I was wondering about is the comments for classes
Aaron> implementing an interface. There's nothing specific about any of the
Aaron> runCommands that should require a specific javadoc and running javadoc
Aaron> will pick up the command of the interface defining the method if there
Aaron> isn't a comment where it's implemented. However that will mean there
Aaron> won't be any comments when one's looking at the actual code.
I wouldn't worry about this.
Aaron> + case JdwpConstants.CommandSet.StringReference.Value:
Constants should be all upper case; this is just a general java style
rule that everybody follows.
Tom