[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[cp-patches] FYI: Fixed BasicScrollBarUI
From: |
Roman Kennke |
Subject: |
[cp-patches] FYI: Fixed BasicScrollBarUI |
Date: |
Thu, 30 Jun 2005 22:05:56 +0200 |
I found some loops in the revalidate and repaint mechanism in Swing.
This patch fixes one of them.
The problem is that we can easily create infinite loops with the
RepaintManager, if you call repaint() and/or revalidate inside the scope
of the paint() or LayoutManager methods. Therefore I advice everybody
who works on Swing to elaborate carefully before placing a repaint() or
revalidate() somewhere. Especially revalidate calls can be very
resource-consuming and are rarely necessary (only when the actual size
of a component changes). I will send some follow-up patches that remove
some more of this stuff.
2005-06-30 Roman Kennke <address@hidden>
* javax/swing/plaf/basic/BasicScrollBarUI.java:
Removed all calls to layoutContainer() in this file.
(installDefaults): Set this as LayoutManager for the JScrollBar.
This way the layoutContainer() method is called when it should
be.
/Roman
01_BasicScrollBarUI.diff
Description: Text Data
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [cp-patches] FYI: Fixed BasicScrollBarUI,
Roman Kennke <=