Re: [cp-patches] Revised patch: JTable and DefaultTableColumnModel

[David Gilbert]

Roman Kennke wrote:

>
> Hi David,
>
>> Attached is a revised version of the patch I proposed late last week.
>> It adds implementations for the isCellEditable() and
>> createDefaultColumnsFromModel() methods in JTable, and fixes some bugs
>> uncovered while writing Mauve tests for the new methods.
>>
>> 2005-07-05  David Gilbert  <address@hidden>
>>
>>     * javax/swing/JTable.java:
>>     (addColumn): retrieve correct column name,
>>     (convertColumnIndexToModel): remove check for > columnCount and let
>>     exception happen,
>>     (getColumnName): retrieve name from TableColumn,
>>     (isCellEditable): implemented,
>>     (createDefaultColumnsFromModel): implemented.
>>     * javax/swing/table/DefaultTableColumnModel.java:
>>     (addColumn): throw exception for null argument, set correct column
>>     index in TableColumnModelEvent,
>>     (removeColumn): use correct column index,
>>     (moveColumn): move the column, don't swap it. Also added argument
>>     checks,
>>     (getColumnIndex): reimplemented.
>>
>> I've committed more Mauve tests to cover these changes.  OK to commit?
>>  
>>
>
> Looks Ok, please commit.
> /Roman
>
>
>
Thanks.  Committed.

Dave.