[cp-patches] Re: [RFA/JDWP] ThreadGroupReferenceCommandSet.java

[Aaron Luchko]

On Wed, 2005-07-20 at 11:14 -0600, Tom Tromey wrote:
> >>>>> "Aaron" == Aaron Luchko <address@hidden> writes:
> 
> Aaron> 2005-07-12  Aaron Luchko  <address@hidden>
> Aaron>      * 
> gnu/classpath/jdwp/processor/ThreadGroupReferenceCommandSet.java:
> Aaron>        Implemented the ThreadGroupReference CommandSet.
> 
> Aaron> +            throw new NotImplementedException("Command " + command +
> Aaron> +              " not found in String Reference Command Set.");
> 
> I think "String" is wrong here.
> 
> Aaron> +  private void executeParent(ByteBuffer bb, DataOutputStream os)
> Aaron> +    throws JdwpException, IOException
> Aaron> +  {
> Aaron> +    ObjectId oid = idMan.readId(bb);
> Aaron> +    ThreadGroup group = (ThreadGroup) oid.getObject();
> Aaron> +    ThreadGroup parent = group.getParent();
> 
> ThreadGroup.getParent() does a security access check.
> What is the plan here?  One idea would be to use
> AccessController.doPrivileged to perform these actions.
> Or, I suppose that could be done at a higher level in the code that
> dispatches the commands.

As discussed on IRC we'll have PacketProcessor.java implement
PrivilegedAction so all the calls like this will be privileged.

I'm committing this patch with the typo fixed.

thanks, Aaron

jdwpThreadGroup.patch
Description: Text Data