[cp-patches] Patch: FYI: KeyPairGenerator problems

[Casey Marshall]

This fixes some problems with Classpath's DSA key pair generator, and  
removes a useless self-recursive call from KeyPairGenerator.

This patch should fix classpath bugs 22990 and 23120, and has the  
benefit of actually producing good key pairs.

Note that the DSAKeyPairGenerator class should be reformatted, but  
isn't here; I'll follow up sometime with a patch to fix this, and  
some of the rest of the fugly code in gnu.java.security.

2005-08-08  Casey Marshall  <address@hidden>

    PR classpath/23120
    * gnu/java/security/provider/DSAKeyPairGenerator.java
    (<init>): made public; set default values.
    (initialize): just call 'initialize(int,boolean,SecureRandom).'
    (initialize): just call 'initialize(DSAParams,SecureRandom).'
    (initialize): check all values for 'null' before overwriting.
    (initialize): fill in defaults or generate new parameters here.
    (generateKeyPair): don't create parameters; fill in 'random' if
    'null;' use 'random,' not a new Random object, when generating
    random numbers.
    (getDefaults): fix keysize check.

    PR classpath/22990
    * java/security/KeyPairGenerator.java (initialize): do nothing.

Committed,

keypairs.patch.txt
Description: Text document