[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [cp-patches] FYI: check_jni_methods.sh fixlets
From: |
Mark Wielaard |
Subject: |
Re: [cp-patches] FYI: check_jni_methods.sh fixlets |
Date: |
Sat, 13 Aug 2005 19:59:47 +0200 |
On Sat, 2005-08-13 at 15:35 +0200, Mark Wielaard wrote:
> 2005-08-13 Mark Wielaard <address@hidden>
>
> * scripts/check_jni_methods.sh: Don't create temp files in source dir.
> Don't override existing files. Fast fail on errors.
Woops. Then it didn't fail anymore when a problem was encountered.
This makes it properly fail again:
2005-08-13 Mark Wielaard <address@hidden>
* scripts/check_jni_methods.sh: Set and check for PROBLEM.
Committed,
Mark
diff -u -r1.7 check_jni_methods.sh
--- scripts/check_jni_methods.sh 13 Aug 2005 13:36:11 -0000 1.7
+++ scripts/check_jni_methods.sh 13 Aug 2005 17:53:42 -0000
@@ -31,6 +31,7 @@
# Compare again silently.
if diff -ub -0 $TMPFILE $TMPFILE2 | grep '^[+-]Java' | grep -q -v -f
$TMPFILE3; then
+ PROBLEM=1
echo "Found a problem with the JNI methods declared and implemented."
echo "(-) missing in implementation, (+) missing in header files"
@@ -41,7 +42,7 @@
# Cleanup.
rm -f $TMPFILE $TMPFILE2 $TMPFILE3
-if test "$RESULT" = "0" ; then
+if test "$PROBLEM" = "1" ; then
exit 1
fi
signature.asc
Description: This is a digitally signed message part