classpath-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[cp-patches] allow null extensions in GdkPixbufReader


From: Thomas Fitzsimmons
Subject: [cp-patches] allow null extensions in GdkPixbufReader
Date: Sat, 20 Aug 2005 22:38:50 -0400

Hi,

null extensions are allowed when constructing ImageReaders on the
assumption that setInput will be called to finish the reader's
initialization.  This patch fixes
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22886

Tom

2005-08-20  Thomas Fitzsimmons  <address@hidden>

        * gnu/java/awt/peer/gtk/GdkPixbufDecoder.java (findFormatName):
        Just return null when ext == null.

Index: gnu/java/awt/peer/gtk/GdkPixbufDecoder.java
===================================================================
RCS file: 
/cvsroot/classpath/classpath/gnu/java/awt/peer/gtk/GdkPixbufDecoder.java,v
retrieving revision 1.16
diff -u -r1.16 GdkPixbufDecoder.java
--- gnu/java/awt/peer/gtk/GdkPixbufDecoder.java 18 Aug 2005 01:22:00 -0000      
1.16
+++ gnu/java/awt/peer/gtk/GdkPixbufDecoder.java 21 Aug 2005 02:38:48 -0000
@@ -306,7 +306,7 @@
   static String findFormatName(Object ext, boolean needWritable)
   {
     if (ext == null)
-      throw new IllegalArgumentException("extension is null");
+      return null;
 
     if (!(ext instanceof String))
       throw new IllegalArgumentException("extension is not a string");

reply via email to

[Prev in Thread] Current Thread [Next in Thread]