Re: [cp-patches] Proposed: javax.swing.UIManager patch

[Roman Kennke]

Am Dienstag, den 23.08.2005, 13:27 +0000 schrieb David Gilbert:
> This patch does two things primarily:
> 
> (1) corrects a problem where every call to "get" a default value ends up 
> calling the 
> getDefaults() method in the current LookAndFeel, which *creates* a new table 
> of 
> defaults each time it is called (the API docs say it should only be called 
> once - a 
> better name for the method would be createDefaults()).  The solution is to 
> retain a 
> reference to the UIDefaults for the current look and feel, and use that 
> reference in 
> getLookAndFeelDefaults() (and change all the get methods to use 
> getLookAndFeelDefaults());

Sounds reasonable.

> (2) implements the property change mechanism in UIManager using the 
> SwingPropertyChangeSupport class.

Dito.

> I've also added API doc comments.  If the patch is too messy, I'll take some 
> more 
> time to split it into the relevant pieces.

I think many people prefer to have documentation changes and code
changes separate. It would be nice to have this split up. Besides that,
please go ahead and commit.


/Roman