[cp-patches] Re: Make qt-peers build and run out of the box

[Dalibor Topic]

Mark Wielaard wrote:
> Hi,
> 
> We really need Qt 4.0.1 so this updates the requirement.

yep, thanks, that's fine.

> The qt-peer/Makefile.am was also updated to not need any hacking of the
> include paths (this didn't work reliably if the path included multiple
> include directories, like with the default Debian install)

Could you elaborate on that one?

I have no idea what debian does, but I'd guess that your patch breaks
code that uses #include <Qsomething>, the style in trolltech's Qt
examples and docs, rather than #include <QtSomething/Qsomething>. :(

More generally, I'd suggest rewriting the build tool stuff to simply use
a qmake pro file for the qt peers, rather then messing with automake.
That's what Trolltech does in their Qt 4.0.1 release, after all, and
that seems to work just fine on win32, x11 and Mac OS X :)

That would in theory allow us to remove the moc target and all that from
the Malefile.am, and would not require messing with #includes, paths,
letting people chose whatever include style floats their boats [1], and
additionally, allow Sven to hack on the native peers without having to
run through the build system fun required for the rest of GNU Classpath.

So ... I'll look into it, and see what I can do.

> and to use
> the general AM_LDFLAGS and AM_CXXFLAGS (important since the
> CLASSPATH_MODULE flags depend on the architecture/os, or Darwin is
> weird).

Thanks, that's OK, too.

> To make this all work out of the box a small include cleanup
> patch was also needed.

Let's see if using qmake provides a better way, that does not require
messing with #include statements or paths to accomodate for Trolltech's
pkg-config CFLAGS oddities, or Debian-specific Qt 4 packaging problems.

cheers,
dalibor topic