classpath-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [cp-patches] FYI: Added and fixed color defaults in MetalLookAndFeel


From: David Gilbert
Subject: Re: [cp-patches] FYI: Added and fixed color defaults in MetalLookAndFeel
Date: Fri, 09 Sep 2005 08:17:29 +0000
User-agent: Mozilla Thunderbird 1.0.6 (X11/20050728)

Roman Kennke wrote:

Hi,

I added and fixed lots of color defaults in the MetalLookAndFeel. Since
this is a little bit tricky to get right (there are 35 color methods in
MetalTheme, which deliver about 8 colors at all), I also added and fixed a
lot of Mauve tests for this.
Hi Roman,

I took a quick look at the changes you made to the Mauve test for initComponentDefaults():

    // The following does not work, at least not with JDK1.5. Maybe
    // don't use the 'defaults' parameter anymore...
    // UIDefaults defaults = new UIDefaults();
    // laf.initComponentDefaults(defaults);
    UIDefaults defaults = laf.getDefaults();

With this change, you should probably rename the test 'getDefaults()', since this is the method you are really checking now (it will return all the default settings from initComponentDefaults() *plus* some others). The original test intended to isolate just those defaults that are set by initComponentDefaults(), but it sounds like that doesn't work on 1.5 anymore (which is odd).

Regards,

Dave





reply via email to

[Prev in Thread] Current Thread [Next in Thread]