Re: [cp-patches] [RFC] JSSE 1.5 classes and methods

[Andrew John Hughes]

On Mon, 2005-09-12 at 22:33 -0700, Casey Marshall wrote:
> Hi,
> 
> Attached is a patch to implement most of the javax.net.ssl methods  
> and classes introduced in J2SE 1.5.
> 

Great.

> This isn't complete, partly due to missing classes elsewhere  
> (java.security.KeyStore.Builder) and due to the introduction of two  
> enums. To work around the latter, I've created a 'PseudoEnum' class  
> that mostly matches 'Enum,' and extend that for the enums in the JSSE  
> API.
> 
> I'm looking for comments about this approach, since I imagine it is  
> controversial; this looks closely compatible with 1.5, according to  
> japicompat, but I'm not sure if that level of compatibility is close  
> enough. There are a couple alternatives to a new class under 'gnu':
> 
>    - Implement a pre-1.5 java.lang.Enum, and use that.
>    - Don't use any superclass, and treat the two enums as one-off  
> types that contain all the methods they currently inherit from the  
> superclass.
...

I guess I'm okay with this, as long as the new class is temporary and
clearly marked as such -- at least it's better than wasting time
implementing everything twice over in subclasses.  It also makes it much
easier to merge it over to the generics branch, where enums are
available.

> Cheers.
> 
> _______________________________________________
> Classpath-patches mailing list
> address@hidden
> http://lists.gnu.org/mailman/listinfo/classpath-patches

Cheers,
-- 
Andrew :-)

Please avoid sending me Microsoft Office (e.g. Word, PowerPoint)
attachments.
See http://www.fsf.org/philosophy/no-word-attachments.html

No software patents in Europe -- http://nosoftwarepatents.com

"Value your freedom, or you will lose it, teaches history.
`Don't bother us with politics' respond those who don't want to learn."
-- Richard Stallman

Escape the Java Trap with GNU Classpath!
http://www.gnu.org/philosophy/java-trap.html
public class gcj extends Freedom implements Java { ... }

signature.asc
Description: This is a digitally signed message part