classpath-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [cp-patches] Patch: improve error handling in String


From: David Daney
Subject: Re: [cp-patches] Patch: improve error handling in String
Date: Fri, 16 Sep 2005 09:50:00 -0700
User-agent: Mozilla Thunderbird 1.0.6-1.1.fc3 (X11/20050720)

Anthony Green wrote:


We discussed on IRC.  I committed this patch without a message, but
collapsed into one line like so:

  // This shouldn't ever happen.
  throw (InternalError) new InternalError().initCause(e);

After all this discussion I kind of hope this exception _is_ thrown some
day :-)

Sorry to rain on your parade. But all these man-hours of discussion guarantee that this portion of the code is bug free and thus will never be executed.

David Daney.






reply via email to

[Prev in Thread] Current Thread [Next in Thread]