classpath-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [cp-patches] Patch: FYI: fix jgss constants


From: Mark Wielaard
Subject: Re: [cp-patches] Patch: FYI: fix jgss constants
Date: Sat, 17 Sep 2005 23:58:53 +0200

Hi,

On Mon, 2005-09-12 at 12:33 -0600, Tom Tromey wrote:
> I'm checking this in.
> 
> This fixes the jgss constants as discussed on the main classpath list.

To keep the information about what the real values should be I added
added them as specnotes. It might help someone who wants to create a
kerberos implementation and might wonder which constants need to be
remapped.

2005-09-17  Mark Wielaard  <address@hidden>

        * org/ietf/jgss/GSSException.java (BAD_BINDINGS, BAD_MECH,
        BAD_NAME, BAD_NAMETYPE, CONTEXT_EXPIRED, CREDENTIALS_EXPIRED,
        DEFECTIVE_CREDENTIAL, DEFECTIVE_TOKEN, DUPLICATE_TOKEN, FAILURE,
        NO_CONTEXT, NO_CRED, OLD_TOKEN): Document official RFC values.

Committed,

Mark
Index: org/ietf/jgss/GSSException.java
===================================================================
RCS file: /cvsroot/classpath/classpath/org/ietf/jgss/GSSException.java,v
retrieving revision 1.5
diff -u -r1.5 GSSException.java
--- org/ietf/jgss/GSSException.java     12 Sep 2005 18:59:03 -0000      1.5
+++ org/ietf/jgss/GSSException.java     17 Sep 2005 21:55:10 -0000
@@ -95,21 +95,25 @@
 
   /**
    * Channel bindings mismatch error.
+   * @specnote Should be 4 according to RFC 2853.
    */
   public static final int BAD_BINDINGS = 1;
 
   /**
    * Unsupported mechanism requested error.
+   * @specnote Should be 1 according to RFC 2853.
    */
   public static final int BAD_MECH = 2;
 
   /**
    * Invalid name provided error.
+   * @specnote Should be 2 according to RFC 2853.
    */
   public static final int BAD_NAME = 3;
 
   /**
    * Name of unsupported type provided error.
+   * @specnote Should be 3 according to RFC 2853.
    */
   public static final int BAD_NAMETYPE = 4;
 
@@ -125,36 +129,43 @@
 
   /**
    * Specified security context expired error.
+   * @specnote Should be 12 according to RFC 2853.
    */
   public static final int CONTEXT_EXPIRED = 7;
 
   /**
    * Expired credentials detected error.
+   * @specnote Should be 11 according to RFC 2853.
    */
   public static final int CREDENTIALS_EXPIRED = 8;
 
   /**
    * Defective credential error.
+   * @specnote Should be 10 according to RFC 2853.
    */
   public static final int DEFECTIVE_CREDENTIAL = 9;
 
   /**
    * Defective token error.
+   * @specnote Should be 9 according to RFC 2853.
    */
   public static final int DEFECTIVE_TOKEN = 10;
 
   /**
    * General failure, unspecified at GSS-API level.
+   * @specnote Should be 13 according to RFC 2853.
    */
   public static final int FAILURE = 11;
 
   /**
    * Invalid security context error.
+   * @specnote Should be 8 according to RFC 2853.
    */
   public static final int NO_CONTEXT = 12;
 
   /**
    * Invalid credentials error.
+   * @specnote Should be 7 according to RFC 2853.
    */
   public static final int NO_CRED = 13;
 
@@ -188,6 +199,7 @@
    * code that may occur during context establishment.  It is not used to
    * indicate supplementary status values.  The MessageProp object is used
    * for that purpose.
+   * @specnote Should be 20 according to RFC 2853.
    */
   public static final int DUPLICATE_TOKEN = 19;
 
@@ -196,6 +208,7 @@
    * that may occur during context establishment.  It is not used to
    * indicate supplementary status values.  The MessageProp object is used
    * for that purpose.
+   * @specnote Should be 19 according to RFC 2853.
    */
   public static final int OLD_TOKEN = 20;
 

Attachment: signature.asc
Description: This is a digitally signed message part


reply via email to

[Prev in Thread] Current Thread [Next in Thread]