classpath-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[cp-patches] FYI: JScrollPane fixup


From: Roman Kennke
Subject: [cp-patches] FYI: JScrollPane fixup
Date: Fri, 23 Sep 2005 22:29:02 +0200 (CEST)
User-agent: SquirrelMail/1.4.4

Hi,

the JAPI pages pointed me to JScrollPane and the BasicScrollPaneUI.
Obviously the implementation has been a little wrong here. There was a lot
of logic implemented in JScrollPane that should have been implemented in
BasicScrollPaneUI. I move the bits over and added some stuff so now the
BasicScrollPaneUI is pretty much complete except for the keyboard and
mouse wheel handling. (Unfortunatly the scrollpane is still not working
100% ok).

2005-09-23  Roman Kennke  <address@hidden>
        * javax/swing/JScrollPane.java
        (setHorizontalScrollBar): Removed handling of listeners on the model.
        This is now done in the BasicScrollPaneUI.
        (setHorizontalScrollBarPolicy): Added revalidate call.
        (setVerticalScrollBar): Removed handling of listeners on the model.
        This is now done in the BasicScrollPaneUI.
        (setVerticalScrollBarPolicy): Added revalidate call.
        (setViewport): Removed handling of listeners on the viewport.
        This is now done in the BasicScrollPaneUI.
        (createScrollListener): Removed unnecessary and undocumented method.
        The functionality of this method is moved to BasicScrollPaneUI
        as specified.
        (JScrollPane): Removed initialization of removed listener.
        * javax/swing/plaf/basic/BasicScrollPaneUI.java
        (HSBChangeListener): New inner class.
        (VSBChangeListener): New inner class.
        (ViewportChangeHandler): New inner class.
        (PropertyChangeHandler): New inner class.
        (MouseWheelHandler): New inner class.
        (installUI): Also call installListeners.
        (installListeners): New method. Initializes the listeners on the
        scrollpane.
        (createHSBChangeListener): New method.
        (createVSBChangeListener): New method.
        (createViewport): New method.
        (createPropertyChangeListener): New method.
        (uninstallUI): Also call uninstallListeners.
        (uninstallListeners): New method.
        (syncScrollPaneWithViewport): New method.
        (updateColumnHeader): New method.
        (updateRowHeader): New method.
        (updateScrollBarDisplayPolicy): New method.
        (updateViewport): New method.
/Roman

Attachment: ScrollPane.diff
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]