classpath-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [cp-patches] [generics] Patch: FYI: first draft of Formatter


From: Mark Wielaard
Subject: Re: [cp-patches] [generics] Patch: FYI: first draft of Formatter
Date: Sun, 25 Sep 2005 19:55:13 +0200

Hi Tom,

On Sat, 2005-09-24 at 20:48 -0600, Tom Tromey wrote:
> I didn't put this on the trunk
> because it is incomplete, it includes a new enum type, and it uses
> varargs.  (The enum seems kind of useless and we could strip the
> varargs for the trunk; once the javadoc is written.)

I don't think we should spend too much time trying to backport this kind
of stuff that actually needs 1.5 language extensions. It has the
potential for very subtle compatibility bugs.

I didn't review it very carefully, but I spotted this one:

> +  private static final String lineSeparator
> +    = System.getProperty("line.separator");

The class could be initialized from an unprivileged context so you need
to get this property through gnu.classpath.SystemProperties.getProperty

Cheers,

Mark

Attachment: signature.asc
Description: This is a digitally signed message part


reply via email to

[Prev in Thread] Current Thread [Next in Thread]