Re: [cp-patches] Patch: javax.sound.midi

[Tom Tromey]

>>>>> "Anthony" == Anthony Green <address@hidden> writes:

Anthony> Here's a virtually complete javax.sound.midi implementation.
Anthony> No providers yet.
Anthony> Ok?

I took a quick look through this.

I think this is looking great.  I think it is OK to go in.

First though, some minor nits, one real bug:


I think @author should have your full name, like:

    @author Anthony Green (address@hidden)

Each class' javadoc should say '@since 1.3'.

At least ShortMessage.clone() uses 'new ShortMessage(...)'.
This doesn't work if the class is extended.  You must write:

  try
    {
      ShortMessage dup = (ShortMessage) super.clone();
      .. set fields
    }
  catch (CloneNotSupportedException _)
    {
      .. I forget what we decided here
      .. look for other examples
    }

I didn't look to see if this occurs elsewhere.

There are one or two places where the code goes past column 79.
(I'm not super concerned about this.  I think we need a reformatting
flag day anyway.)

Tom