classpath-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [cp-patches] RFC: 2 swing.text.Utilities methods implemented


From: Roman Kennke
Subject: Re: [cp-patches] RFC: 2 swing.text.Utilities methods implemented
Date: Wed, 28 Sep 2005 09:25:56 +0200

Hi Tony,

Am Dienstag, den 27.09.2005, 12:47 -0400 schrieb Anthony Balkissoon:
> On Roman's advice, I changed the 2 methods to use binary searching
> rather than sequential searching.  This is now committed.

please please please write Mauve tests for the Utilities class methods.
These are quite low-level methods that are supposed to be used by
several components. Imagine what happens if they do not work correctly
and we implement the other components against the wrong behaviour.

Please try to create some testcases that cover the general case, and
make up your mind about some special cases that might happen (like a
search through a "" string, start searching directly on an '\n',
starting search at the beginning/end of the string etc.

The same goes for SimpleAttributeSet and most other stuff in
javax.swing.text that is not View-related. This package is all too
fragile and badly documented, so we nearly have no choice here.

Thank you,
/Roman

Attachment: signature.asc
Description: Dies ist ein digital signierter Nachrichtenteil


reply via email to

[Prev in Thread] Current Thread [Next in Thread]