classpath-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [cp-patches] RFC: Fix for JComboBox drop down list


From: David Gilbert
Subject: Re: [cp-patches] RFC: Fix for JComboBox drop down list
Date: Fri, 30 Sep 2005 20:16:50 +0000
User-agent: Mozilla Thunderbird 1.0.6 (X11/20050728)

Lillian Angel wrote:

2005-09-29  David Gilbert  <address@hidden>

   * javax/swing/JPopupMenu.java
   (setVisible): use current size, not preferred size, when checking for
   screen edge,

Actually, you should use the preferredSize. This gets the preferredSize
of each menuitem- which returns the size with the correct spacing for
the accelerators, icons etc. By doing this, the menu's will be painted
at the correct size.

I fixed this and I will commit it soon.
We'll need to find some other way to make this work for JComboBoxes then - the drop down list width must match the width of the JComboBox, irrespective of the preferred size.

Regards,

Dave




reply via email to

[Prev in Thread] Current Thread [Next in Thread]