[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [cp-patches] RFC: MetalToolTipUI and BasicToolTipUI
From: |
Lillian Angel |
Subject: |
Re: [cp-patches] RFC: MetalToolTipUI and BasicToolTipUI |
Date: |
Tue, 04 Oct 2005 11:22:01 -0400 |
Fixed
2005-10-04 Lillian Angel <address@hidden>
* javax/swing/plaf/metal/MetalToolTipUI.java
(paint): Added space around the toolTip's accelerator.
(fetchAcceleratorString): Added code to get mnemonic for
JMenuItem if it does not have an accelerator.
On Tue, 2005-10-04 at 11:13 -0400, Lillian Angel wrote:
> I have tested this and the mnemonics are not being shown if the
> accelerator is null. Also there should be more space around the
> accelerator in the tooltip. Looks a little crammed.
>
> I am working on fixing this. I will let you know how it goes.
>
> Lillian
>
> On Tue, 2005-10-04 at 15:13 +0000, David Gilbert wrote:
> > Lillian Angel wrote:
> >
> > >On Tue, 2005-10-04 at 12:39 +0000, David Gilbert wrote:
> > >
> > >
> > >>I decided to implement the missing methods in MetalToolTipUI. As far as
> > >>I can tell,
> > >>tooltips for buttons and menu items under the MetalLookAndFeel display
> > >>the
> > >>accelerator text in the tooltip, but under the BasicLookAndFeel they do
> > >>not. So the
> > >>accelerator code in BasicToolTipUI needs moving to MetalToolTipUI.
> > >>
> > >>This patch cleans up both classes - I'm asking for review and comments
> > >>because it is
> > >>a reasonably big change to BasicToolTipUI and it is possible that I've
> > >>missed
> > >>something. Here is the ChangeLog:
> > >>
> > >>2005-10-04 David Gilbert <address@hidden>
> > >>
> > >> * javax/swing/plaf/basic/BasicToolTipUI.java
> > >> (accText): removed,
> > >> (accDeliminator): removed,
> > >> (accFont): removed,
> > >> (accFore): removed,
> > >> (getPreferredSize): removed accelerator code (now in MetalToolTipUI),
> > >> (getAcceleratorText): removed (equivalent is now in MetalToolTipUI),
> > >> (paint): removed accelerator painting,
> > >> * javax/swing/plaf/metal/MetalToolTipUI.java
> > >> (padSpaceBetweenStrings): new field,
> > >> (MetalToolTipUI): initialise defaults,
> > >> (getAcceleratorString): new method,
> > >> (installUI): new method,
> > >> (uninstallUI): new method,
> > >> (isAcceleratorHidden): new method,
> > >> (getPreferredSize): new method,
> > >> (paint): new method,
> > >> (fetchAcceleratorString): new private method,
> > >> (acceleratorToString): new private method,
> > >> * examples/gnu/classpath/examples/swing/Demo.java
> > >> (mkButton): set tool tip.
> > >>
> > >>Comments?
> > >>
> > >>
> > >
> > >Looks fine to me :)
> > >Lillian
> > >
> > >
> > >
> > >
> > >
> > Thanks. Committed.
> >
> > Regards,
> >
> > Dave
>
>
>
> _______________________________________________
> Classpath-patches mailing list
> address@hidden
> http://lists.gnu.org/mailman/listinfo/classpath-patches
patch.diff
Description: Text Data