classpath-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [cp-patches] [PATCH] Fix PR classpath/24086, PR classpath/24091, PR


From: Jeroen Frijters
Subject: RE: [cp-patches] [PATCH] Fix PR classpath/24086, PR classpath/24091, PR classpath/24104 et al. ...
Date: Wed, 12 Oct 2005 07:08:51 +0200

David Daney wrote:
> This is the new version of my HTTP patch.  It keeps promoting (near) 
> silence from the approvers, and I keep finding and fixing new bugs. 
> Also it has been about a week and I fixed another bug, so I thought I 
> would post the current version.

Thanks for this rewrite. I reviewed the patch and it looks good. I have
two small nitpicks:

+    if (-1 == r)

In Java this isn't really needed (as you can't accidentally do an assign
here anyway), so it is uncommon to put the constant first.

LimitedLengthInputStream shouldn't have a finalize().

> OK to commit?

I vote yes.

Regards,
Jeroen




reply via email to

[Prev in Thread] Current Thread [Next in Thread]