[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [cp-patches] FYI: BasicTreeUI fix
From: |
Lillian Angel |
Subject: |
Re: [cp-patches] FYI: BasicTreeUI fix |
Date: |
Tue, 18 Oct 2005 13:45:53 -0400 |
Noticed the expanded and collapsed icon defaults were set to the wrong
icons. Fixed this and reworked mousePressed to work with these changes.
2005-10-18 Lillian Angel <address@hidden>
* javax/swing/plaf/basic/BasicTreeUI.java:
Removed leafIcon field.
(BasicTreeUI): Removed leafIcon initialization.
(installDefaults): Icon defaults were wrong, fixed.
(isLocationInExpandControl): Fixed to incorporated gap.
(mousePressed): Fixed to include correct icon widths. Sometimes
the labels icon is different from what the tree's default icon
is set to. Added a check for this.
(getCellBounds): No need to include gap here.
(getCurrentControlIcon): Fixed to use expandedIcon and
collapsedIcon.
(paintRow): No need paint beyond preferred width of tree here.
(updateCurrentVisiblePath): If nothing is selected, the root
should be selected without focus.
* javax/swing/plaf/metal/MetalTreeUI.java
(installDefaults): Fixed defaults for the expanded/collapsed
icons.
On Mon, 2005-10-17 at 14:46 -0400, Lillian Angel wrote:
> Now this is completely fixed.
>
> 2005-10-17 Lillian Angel <address@hidden>
>
> * javax/swing/plaf/basic/BasicTreeUI.java
> (installUI): Moved call to installKeyboardActions and Listeners
> to before expansion of root.
> (paint): Added check to make sure the cached visible path is
> updated.
> (treeExpanded): Added call to update visible path.
> (treeCollapsed): Likewise.
> (treeNodesChanged): Likewise.
> (treeNodesInserted): Likewise.
> (treeNodesRemoved): Likewise.
> (treeStructureChanged): Likewise.
> (paintRecursive): Moved code to paintRow.
> (paintControlIcons): Fixed to paint custom control icons
> properly.
> (paintExpandControl): Removed unneeded parameter.
> (paintRow): Added code to paint the row with the correct width.
> * javax/swing/plaf/metal/MetalTreeUI.java
> (installUI): Moved code to expand the root after all the
> listeners have been initialized.
>
> On Fri, 2005-10-14 at 17:42 -0400, Lillian Angel wrote:
> > After testing some new apps, I noticed that there was a slight problem
> > with some custom icons. I almost have it fixed completely.
> >
> > 2005-10-14 Lillian Angel <address@hidden>
> >
> > * javax/swing/LookAndFeel.java
> > (makeIcon): Implemented.
> > * javax/swing/plaf/basic/BasicTreeUI.java
> > (updateCachedPreferredSize): Should only add with of control
> > icon if
> > not a leaf.
> > (mousePressed): Fixed to use new gap field.
> > (paintRecursive): Likewise.
> > (paintRow): Likewise.
> > (updateCurrentVisiblePath): Shouldn't include root if it is
> > not of a valid size to be painted.
> >
> > _______________________________________________
> > Classpath-patches mailing list
> > address@hidden
> > http://lists.gnu.org/mailman/listinfo/classpath-patches
> _______________________________________________
> Classpath-patches mailing list
> address@hidden
> http://lists.gnu.org/mailman/listinfo/classpath-patches
patch.diff
Description: Text Data