[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[cp-patches] Re: RFC: Don't call protected addURL() method from URLClass
[cp-patches] Re: RFC: Don't call protected addURL() method from URLClassLoader constructors
Wed, 19 Oct 2005 18:09:15 +0100
Mark Wielaard writes:
> Hi Andrew,
> On Wed, 2005-10-19 at 17:36 +0100, Andrew Haley wrote:
> > > 2005-10-19 Mark Wielaard <address@hidden>
> > >=20
> > > * java/net/URLClassLoader.java (addURLs): Don't call addURL(), but
> > > call urls.add() and addURLImpl() directly on each URL.
> > >=20
> > > Andrew, I know you hacked on this code to get Jonas running nicely.
> > > Could you check that this doesn't break anything for you? We don't want
> > > to loose that nice 96.79% success rate!
> > You really shouldn't consider committing a patch like this without
> > adding comments. After all, what is to stop someone changing it back?
> Testing of know good applications.
Yeah, right. :-)
> But I see your point. Does the attached work for you?
Seems to pass basic smoke tests. The Online Store demo works OK.