[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [cp-patches] FYI: Providing workarounds for com.sun.CORBA.connection

From: Roman Kennke
Subject: Re: [cp-patches] FYI: Providing workarounds for com.sun.CORBA.connection.ORBSocketFactoryClass property (or ORBConstants.SOCKET_FACTORY_CLASS_PROPERTY field).
Date: Tue, 25 Oct 2005 08:36:07 +0200

Hi Audrius,

> The new  property gnu.Corba.SocketFactory replaces the socket factory 
> for the ORB being currently instantiated and should help with 
> adaptation. The factory must implement 
> gnu.CORBA.interfaces.gnuSocketFactory.

One question that I asked myself for some time now: is there a specific
reason why you deviate from the our naming convention for classes (lower
case first letters or _ for classes and method names?)

Also I noticed that you ChangeLog entries are a little uncommon, you use
spaces instead of TABs for indendation and not all filenames are
preceded by a *. I think this could matter for automatic parsing of
ChangeLog files. At least in emacs it becomes immediately obvious
(that's how I spotted those), because the entries get nice coloring when
properly formatted.

Besides that your work looks _really_ good, I like especially that you
document every piece of code. Unfortunately I cannot test it, because I
have absolutely no clue about CORBA :-(

Cheers, Roman

Attachment: signature.asc
Description: Dies ist ein digital signierter Nachrichtenteil

reply via email to

[Prev in Thread] Current Thread [Next in Thread]