classpath-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [cp-patches] RFC: gnu/java/nio/charset/iconv/IconvProvider.java


From: Mark Wielaard
Subject: Re: [cp-patches] RFC: gnu/java/nio/charset/iconv/IconvProvider.java
Date: Sat, 05 Nov 2005 13:47:12 +0100

Hi Ito,

On Sat, 2005-11-05 at 02:01 +0900, Ito Kazumitsu wrote:
> This path should fix the bug #22968 (gnu.java.nio.charset.iconv.IconvProvider:
> the constructor must be public).
> 
> This patch has already been applied in Kaffe for several months
> and has worked fine.
> 
> 
> 2005-11-04  Ito Kazumitsu  <address@hidden>
> 
>       * gnu/java/nio/charset/iconv/IconvProvider.java
>       (IconvProvider): Declare the constructor public.

Yes, this looks fine. Thanks for writing extensive comments in the
source why this is necessary.

If you add the bug number to the ChangeLog message (and use it as cvs
commit message) bugzilla will be automatically notified of the change.
So please use something like:

        Fixes bug #22968.
        * gnu/java/nio/charset/iconv/IconvProvider.java
        (IconvProvider): Declare the constructor public.

Then a few minutes after you commit with that message the bug should be
updated with your changelog message:
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22968

Cheers,

Mark

Attachment: signature.asc
Description: This is a digitally signed message part


reply via email to

[Prev in Thread] Current Thread [Next in Thread]