Re: [cp-patches] Patch: File.getParent fixlet

[Mark Wielaard]

Hi Wolfgang,

On Sun, 2005-11-06 at 19:06 +0100, Wolfgang Baer wrote:
> These are the fixlets needed to make java.io.File pass the submitted
> mauve tests for an empty file ( new File("") ).
> 
> 2005-11-06  Wolfgang Baer  <address@hidden>
> 
>          * java/io/File.java
>            (getParent): If pathname is "" return null.
>            (toURI): Also append separatorChar if path equals "".
>            (getAbsolutePath): If path equals "" only return the value
>             of the user.dir system property.

OK, so File("") is almost like File(".").

The method names in a ChangeLog entry are not indented extra, just one
tab. So please write it as:

2005-11-06  Wolfgang Baer  <address@hidden>

        * java/io/File.java
        (getParent): If pathname is "" return null.
        (toURI): Also append separatorChar if path equals "".
        (getAbsolutePath): If path equals "" only return the value
        of the user.dir system property.


> +    else if (path.equals(""))
> +       return System.getProperty ("user.dir");
>      else
>        return System.getProperty ("user.dir") + separatorChar + path;

Everything is indented the same (2 spaces):

        else if (path.equals(""))
          return System.getProperty ("user.dir");
        else
          return System.getProperty ("user.dir") + separatorChar + path;

Please commit with those changes.

Thanks,

Mark

signature.asc
Description: This is a digitally signed message part