Re: [cp-patches] Patch: implemented InvocationEvent.getThrowable

[Mark Wielaard]

Hi Tony,

On Mon, 2005-11-07 at 13:29 -0500, Anthony Balkissoon wrote:
> JAPI pointed out that InvocationEvent.getThrowable was missing.  I wrote
> it, which involved a slight tweak of dispatch() as well.
> [...]
> +  /**
> +   * Returns a throwable caught while executing the Runnable's run() method.
> +   * Null if none was thrown or if this InvocationEvent doesn't catch
> +   * throwables.
> +   * @return the caught Throwable
> +   */
> +  public Throwable getThrowable()
> +  {
> +    return throwable;
> +  }

Please add @since 1.5 to such new methods.
Now we have both a throwable and a exception private field. Unless we
need them for serialization it is probably better to collapse them into
one and let getException() do an instanceof Exception.

Cheers,

Mark

signature.asc
Description: This is a digitally signed message part