Re: [cp-patches] RFC: new VM interface for Socket impls

[Mark Wielaard]

Hi,

On Wed, 2005-11-09 at 21:16 +0000, Roman Kennke wrote:
> Ingo has abstracted out the native code from gnu.java.net.PlainSocketImpl
> and gnu.java.net.PlainDatagramSocketImpl into a new VM interface. This
> allows VM implementors to provide a different implementation for the
> native parts of these classes if they wish. Is this ok to commit as it
> is? Do you have any suggestions/improvements to the interface? We would
> like to have a stable VM interface for this area, so maybe it would be
> helpful to discuss this with other VM implementors...

Great idea! This is one area where there is a large divergence between
classpath and libgcj because we never had VMClasses here. IKVM also has
a completely different implementation of these classes. So I hope Jeroen
also can take a look.

I have attached just the VM files to give others an idea what we want to
use. I'll comment some more after I have looked at the libgcj sources. A
first comment is that for the VM reference implementation I would just
make all methods native directly, no need to chain them to some helper
method here. Is there a reason that only nativeLeave() is synchronized?

After we agree on this VM interface (and I think it is good, I just want
to try it out first) we can discuss the rest of the patch. Just one
quick nitpick now already: please keep the boilerplate at the top of the
file intact, some of the files in the patch have the old FSF address.

Cheers,

Mark

VMPlainSocketImpl.java
Description: Text Data

VMPlainDatagramSocketImpl.java
Description: Text Data

signature.asc
Description: This is a digitally signed message part