classpath-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[cp-patches] Patch: fixlet for JComponent


From: Anthony Balkissoon
Subject: [cp-patches] Patch: fixlet for JComponent
Date: Mon, 14 Nov 2005 16:02:31 -0500

Lillian pointed out that JComponent was giving some NPEs.  This is
probably because last week I removed some unnecessary code from
addNotify but forgot to remove the corresponding code from removeNotify.
This is fixed now.  While I was there I also added a FIXME note to
remind myself to remove the WHEN_IN_FOCUSED_WINDOW bindings for this
component, but first I have to write that capability into the
KeyboardManager.  This will take some thought as I have to improve the
performance of KeyboardManager when it comes to removing/updating
bindings.

I also added a FIXME in JMenuBar's removeNotify to unregister the
JMenuBar.  Again, I have to write the capability into the
KeyboardManager first.  This one is pretty easy.


2005-11-14  Anthony Balkissoon  <address@hidden>

        * javax/swing/JComponent.java:
        (removeNotify): Removed unncessary InputMap and ActionMap inheritance
        code. Added FIXME to remove the WHEN_IN_FOCUSED_WINDOW bindings from 
        the KeyboardManager.
        * javax/swing/JMenuBar.java:
        (removeNotify): Added FIXME to unregister this JMenuBar from the 
        KeyboardManager.

--Tony

Attachment: JComponentRemoveNotify.diff
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]