classpath-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[cp-patches] FYI: Basic L&F cleanup


From: Roman Kennke
Subject: [cp-patches] FYI: Basic L&F cleanup
Date: Tue, 15 Nov 2005 20:36:38 +0000

Hi,

I cleaned up javax.swing.plaf.basic a little. For the most part this
replaces all occurances of UIManager.getLookAndFeelDefaults().getXXX()
with UIManager.getXXX(). Not only is this shorter, it also has a
slightly different semantics (or should have, I'll explain this later
when I implement/fix this).

I also took out some caching in BasicToolBarUI, that caused problems with
the jIRCii app that I tried out. I will have to look into this issue in
more detail later.

2005-11-15  Roman Kennke  <address@hidden>

        * javax/swing/plaf/basic/BasicBorders.java
        (getButtonBorder): Replaced UIManager.getLookAndFeelDefaults().get()
        with UIManager.get().
        (getRadioButtonBorder): Replaced
        UIManager.getLookAndFeelDefaults().get() with UIManager.get().
        (getToggleButtonBorder): Replaced
        UIManager.getLookAndFeelDefaults().get() with UIManager.get().
        (getMenuBarBorder): Replaced
        UIManager.getLookAndFeelDefaults().get() with UIManager.get().
        (getSplitPaneBorder): Replaced
        UIManager.getLookAndFeelDefaults().get() with UIManager.get().
        (getSplitPaneDividerBorder): Replaced
        UIManager.getLookAndFeelDefaults().get() with UIManager.get().
        (getTextFieldBorder): Replaced
        UIManager.getLookAndFeelDefaults().get() with UIManager.get().
        (getInternalFrameBorder): Replaced
        UIManager.getLookAndFeelDefaults().get() with UIManager.get().
        * javax/swing/plaf/basic/BasicButtonUI.java
        (paintText): Replaced UIManager.getLookAndFeelDefaults().get()
        with UIManager.get().
        * javax/swing/plaf/basic/BasicCheckBoxUI.java
        (getDefaultIcon): Replaced UIManager.getLookAndFeelDefaults().get()
        with UIManager.get().
        * javax/swing/plaf/basic/BasicComboBoxUI.java
        (paintCurrentValue): Replaced UIManager.getLookAndFeelDefaults().get()
        with UIManager.get().
        * javax/swing/plaf/basic/BasicFileChooserUI.java
        (installStrings): Replaced UIManager.getLookAndFeelDefaults().get()
        with UIManager.get().
        * javax/swing/plaf/basic/BasicInternalFrameTitlePane.java
        (installDefaults): Replaced UIManager.getLookAndFeelDefaults().get()
        with UIManager.get().
        * javax/swing/plaf/basic/BasicListUI.java
        (installKeyboardActions): Replaced
        UIManager.getLookAndFeelDefaults().get() with UIManager.get().
        * javax/swing/plaf/basic/BasicProgressBarUI.java
        (boxRect): Added @since tag to the API comment.
        * javax/swing/plaf/basic/BasicRadioButtonUI.java
        (getDefaultIcon): Replaced UIManager.getLookAndFeelDefaults().get()
        with UIManager.get().
        * javax/swing/plaf/basic/BasicScrollBarUI.java
        (configureScrollBarColors): Replaced
        UIManager.getLookAndFeelDefaults().get() with UIManager.get().
        (calculatePreferredSize): Fetch preferred width or height from
        UI defaults.
        * javax/swing/plaf/basic/BasicTableUI.java
        (installKeyboardActions): Replaced
        UIManager.getLookAndFeelDefaults().get() with UIManager.get().
        * javax/swing/plaf/basic/BasicTextUI.java
        (createKeymap): Replaced
        UIManager.getLookAndFeelDefaults().get() with UIManager.get().
        (getInputMap): Replaced
        UIManager.getLookAndFeelDefaults().get() with UIManager.get().
        (getActionMap): Replaced
        UIManager.getLookAndFeelDefaults().get() with UIManager.get().
        * javax/swing/plaf/basic/BasicToolBarUI.java
        (dragTo): Don't use cached* fields.
        (installComponents): Don't use cached* fields.
        * javax/swing/plaf/basic/BasicTreeUI.java
        (getHashColor): Replaced
        UIManager.getLookAndFeelDefaults().get() with UIManager.get().
        (setHashColor): Replaced
        UIManager.getLookAndFeelDefaults().get() with UIManager.get().
        Added FIXME comment.
        (installKeyboardActions): Replaced
        UIManager.getLookAndFeelDefaults().get() with UIManager.get().

/Roman

Attachment: patch.diff
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]