classpath-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[cp-patches] FYI: BasicTabbedPane fixup


From: Roman Kennke
Subject: [cp-patches] FYI: BasicTabbedPane fixup
Date: Fri, 18 Nov 2005 21:58:29 +0000

This fixes several bugs in BasicTabbedPaneUI that I had with an app that
makes extensive use of this UI class.

2005-11-17  Roman Kennke  <address@hidden>

        * javax/swing/plaf/basic/BasicTabbedPaneUI.java
        (PropertyChangeHandler.propertyChange): Replaced layout() call
        with revalidate() call.
        (TabbedPaneLayout.calculateLayoutInfo): Added assureRectsCreated()
        call to make sure we have the rectangles in place. Also initialize
        the contentRect here so it can be used later.
        (TabbedPaneLayout.calculateSize): Removed unused statement.
        (TabbedPaneLayout.calculateTabRects): Moved assureRectsCreated
call
        to calculateLayoutInfo().
        (TabbedPaneScrollLayout.calculateTabRects): Moved
        assureRectsCreated call to calculateLayoutInfo(). Removed unused
        statements.
        (TabbedPaneScrollLayout.layoutContainer): Replaced hide() and
show()
        calls with calls to setVisible(). Especially important since
        setVisible is handled special in Swing.
        (BasicTabbedPaneUI): Initialize rects and tabRuns fields.
        (installUI): Removed layout() call.
        (paintContentBorder): Removed unused statement.
        (assureRectsCreated): Reworked to match the JDK behaviour.
        (getFontMetrics): Use the component getFontMetrics() instead of
        the deprecated toolkit method.

/Roman

Attachment: patch.diff
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]