Re: [cp-patches] RFC: GdkGraphics fix

[Thomas Fitzsimmons]

On Mon, 2005-11-21 at 14:33 -0500, Lillian Angel wrote:
> This fixes bug # 24937
> I spoke in detail to Roman about this. 
> drawString(String...) was changed to call
> drawString(AttributedCharacterIterator...) because they both need to
> ignore the newline characters. 
> 
> drawString(AttributedCharacterIterator...) iterates through the
> characters and stores the non-newline chars in an array. Here Roman
> suggested that I make some changes and pass the char[] to the native
> drawString function because allocating a new String is not ideal.
> 
> I tried doing this, but that native function calls getStringUTFChars
> (which requires a jstring). Removing the call to getStringUTFChars
> obviously does not work... 
> 
> The best way to do this right now (since
> drawString(AttributedCharacterIterator...) is not fully implemented), is
> creating a new String, like I have done in this patch, or call
> replaceAll("\n", "") on the String. replaceAll does a lot of unnecessary
> things, so I avoided using it.

Why bring the AttributedCharacterIterator drawString into this?  Why not
just create a new string in "drawString (String str, int x, int y)"
using something like String.replaceAll?

Also, is it enough to check for '\n'?  Are there other Unicode
formatting characters we should filter out?

Tom

> 
> Can someone please look over this patch and let me know if it is okay to
> commit?
> 
> Thanks!
> 
> 
> 2005-11-21  Lillian Angel  <address@hidden>
> 
>         PR classpath/PR24937
>         * gnu/java/awt/peer/gtk/GdkGraphics.java
>         (drawString): Changed to call drawString with
>         AttributedCharacterIterator.
>         (drawString): Partially implemented to iterate through
>         the characters, removing all newlines. Now newlines are
>         not drawn.
> 
> _______________________________________________
> Classpath-patches mailing list
> address@hidden
> http://lists.gnu.org/mailman/listinfo/classpath-patches