[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [cp-patches] RFC: BasicComboBoxUI minimum size caching
From: |
Mark Wielaard |
Subject: |
Re: [cp-patches] RFC: BasicComboBoxUI minimum size caching |
Date: |
Mon, 21 Nov 2005 23:09:45 +0100 |
Hi Roman,
On Mon, 2005-11-21 at 22:23 +0100, Roman Kennke wrote:
> Looks ok. Except that the cache is possibly invalidated a little too
> often. I would think that the focus state doesn't change the
> minimumSize. Also, the general propertyChange() invalidation is maybe
> not good. But still ok to check in.
Yeah, you are right it isn't that likely to trigger a size change. But
we didn't do any caching before. And custom look and feels seem to do
lots of interesting tweaks. So I like to be a bit paranoid here.
Checking this in as is now. If someone feels they can optimize it and
that is worth it then please do.
Cheers,
Mark
signature.asc
Description: This is a digitally signed message part