classpath-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [cp-patches] FYI: Stopping the DefaultCaret timer when the component


From: Meskauskas Audrius
Subject: Re: [cp-patches] FYI: Stopping the DefaultCaret timer when the component looses the focus.
Date: Tue, 22 Nov 2005 16:26:16 +0100
User-agent: Mozilla Thunderbird 1.0.2 (Windows/20050317)

Despite the current version always operates correctly, yes, the timer generally must be started regardless if the caret is now visible or not (it may get visible due blinking). I was also thinking about the version where the "visible" property is not involved into the blinking process, but in this case the custom caret does not blink.

2005-11-22  Audrius Meskauskas  <address@hidden>

* javax/swing/text/DefaultCaret.java (updateTimerStatus): Ignore the field "visible".
Index: javax/swing/text/DefaultCaret.java
===================================================================
RCS file: /cvsroot/classpath/classpath/javax/swing/text/DefaultCaret.java,v
retrieving revision 1.25
diff -u -r1.25 DefaultCaret.java
--- javax/swing/text/DefaultCaret.java  22 Nov 2005 10:05:31 -0000      1.25
+++ javax/swing/text/DefaultCaret.java  22 Nov 2005 14:54:02 -0000
@@ -457,7 +457,7 @@
    */
   private void updateTimerStatus()
   {
-    if (visible && textComponent.isEnabled() && textComponent.isEditable())
+    if (textComponent.isEnabled() && textComponent.isEditable())
       {
         if (blinkTimer == null)
           initBlinkTimer();

reply via email to

[Prev in Thread] Current Thread [Next in Thread]