Re: [cp-patches] Patch: MetalTabbedPaneUI missing functions

[Lillian Angel]

On Wed, 2005-11-23 at 11:40 +0100, Roman Kennke wrote:
> Hi there,
> 
> Am Dienstag, den 22.11.2005, 23:14 -0500 schrieb Thomas Fitzsimmons:
> > On Tue, 2005-11-22 at 16:10 -0500, Lillian Angel wrote:
> > > Added missing functions in MetalTabbedPaneUI. Again, most just call
> > > super.
> > 
> > If these methods just call super then there's no reason to override
> > them.
> 
> I agree.
> 
> >   I'm surprised that JAPI is marking these as missing since they
> > are implemented in the base classes.
> 
> JAPI didn't mark the methods that are implemented in the base class.
> JAPI marked only the methods, that are new in MetalTabbedPaneUI.

My mistake for adding those functions in. I will remove them. The new
ones that JAPI pointed out, I implemented. I will look into them and see
if more needs to be done. Otherwise, I will leave them as is.

>  For
> these methods it would make sense to figure out how they are supposed to
> be called and implement that. Otherwise a subclass that overrides these
> methods won't get the desired functionality.


Lillian